Misc bugfixes (for 0.2.6 release) #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Etcd handles this logic for us automatically, and it was causing issues as the header referred to the key, not cluster, revision.
SimonSchick
approved these changes
Oct 24, 2017
|
Do you think we will see it merged and published soon ? |
|
@connor4312 seems to have a single test case failure. |
|
Hey there, any news ? Would be great to have this soon else I'll need to use another library |
|
Sorry, an emergency came up, I'll release this as soon as I can |
connor4312
force-pushed
the
misc-bugfixes
branch
3 times, most recently
from
05592af
to
ca62f1d
Compare
connor4312
force-pushed
the
misc-bugfixes
branch
from
ca62f1d
to
d58a790
Compare
connor4312
force-pushed
the
misc-bugfixes
branch
from
d58a790
to
d1467be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all the open issues: