Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract the CLI logic for testing #78

Closed
janechu opened this issue Jun 22, 2022 · 0 comments
Closed

Abstract the CLI logic for testing #78

janechu opened this issue Jun 22, 2022 · 0 comments
Assignees
@janechu
Labels
area:dev-ops Pertains to build, CI, and other dev-ops work area:environment Pertains to the development environment category:stability Enhancing stability by updating underlying dependencies/code or adding testing mechanisms improvement A non-feature-adding improvement
Milestone
1.0.0

Comments

@janechu
Copy link
Contributor

janechu commented Jun 22, 2022

Description

Currently the CLI take a long time to test due to the fact that building a project to test the output takes a long time, this would be better served if the generated files were abstracted and only the full project with all components was tested.

Requirements

  • Abstract the files and their contents in such a way that the CLI functions can be called to retrieve this information before it is written to disc.
  • Test a separate function that writes files to disc
@janechu janechu self-assigned this Jun 22, 2022
@janechu janechu added area:dev-ops Pertains to build, CI, and other dev-ops work area:environment Pertains to the development environment category:stability Enhancing stability by updating underlying dependencies/code or adding testing mechanisms improvement A non-feature-adding improvement labels Jun 22, 2022
@janechu janechu added this to the CLI 1.0 milestone Jun 22, 2022
@janechu janechu mentioned this issue Jun 24, 2022
Merged
3 tasks
@janechu janechu mentioned this issue Jun 25, 2022
Merged
3 tasks
janechu added a commit that referenced this issue Jul 7, 2022
@janechu
Extract the package name utility (#82)
38b9286 
# Pull Request

## 📖 Description

<!--- Provide some background and a description of your work. -->
As part of the work to improve testing the `getPackageName` utility has been extracted in this change.

### 🎫 Issues

<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes #411
-->
Continued work on #78

## ✅ Checklist

### General

<!--- Review the list and put an x in the boxes that apply. -->

- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janechu janechu

Labels
area:dev-ops Pertains to build, CI, and other dev-ops work area:environment Pertains to the development environment category:stability Enhancing stability by updating underlying dependencies/code or adding testing mechanisms improvement A non-feature-adding improvement
Projects
FAST Tools Roadmap
Status: Done
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@janechu