-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ESLint migrate definition rule for 1.0.0-alpha.1 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
requested review from
williamw2,
nicholasrice and
EisenbergEffect
as code owners
August 8, 2022 17:12
janechu
force-pushed
the
users/janechu/add-definition-rule
branch
from
August 8, 2022 19:05
92f79ef
to
6936688
Compare
EisenbergEffect
suggested changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provided an updated code sample in a comment. I think this one may be out of date in the GH issue. I'll go fix it now.
packages/eslint-plugin-fast-cli-migrate/src/rules/1.0.0-alpha.1--definition.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fast-cli-migrate/src/rules/1.0.0-alpha.1--definition.md
Outdated
Show resolved
Hide resolved
janechu
force-pushed
the
users/janechu/add-definition-rule
branch
from
August 8, 2022 20:02
f7807f7
to
95335ae
Compare
janechu
force-pushed
the
users/janechu/add-definition-rule
branch
from
August 8, 2022 20:02
95335ae
to
c3f2bca
Compare
packages/eslint-plugin-fast-cli-migrate/src/rules/1.0.0-alpha.1--definition.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fast-cli-migrate/src/rules/1.0.0-alpha.1--definition.ts
Outdated
Show resolved
Hide resolved
janechu
force-pushed
the
users/janechu/add-definition-rule
branch
from
August 8, 2022 22:00
9189d67
to
c9890d5
Compare
EisenbergEffect
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
This change adds a rule to update components
*.definition.ts
files for the newest version update.π« Issues
Continues work on #41
β Checklist
General