Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ESLint migrate definition rule for 1.0.0-alpha.1 #108

Merged
merged 7 commits into from
Aug 8, 2022

Conversation

janechu
Copy link
Contributor

@janechu janechu commented Aug 8, 2022

Pull Request

πŸ“– Description

This change adds a rule to update components *.definition.ts files for the newest version update.

🎫 Issues

Continues work on #41

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided an updated code sample in a comment. I think this one may be out of date in the GH issue. I'll go fix it now.

@janechu janechu force-pushed the users/janechu/add-definition-rule branch from f7807f7 to 95335ae Compare August 8, 2022 20:02
@janechu janechu force-pushed the users/janechu/add-definition-rule branch from 95335ae to c3f2bca Compare August 8, 2022 20:02
@EisenbergEffect EisenbergEffect self-requested a review August 8, 2022 20:10
@janechu janechu force-pushed the users/janechu/add-definition-rule branch from 9189d67 to c9890d5 Compare August 8, 2022 22:00
@EisenbergEffect EisenbergEffect self-requested a review August 8, 2022 22:18
@janechu janechu merged commit 62bb8e9 into main Aug 8, 2022
@janechu janechu deleted the users/janechu/add-definition-rule branch August 8, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants