Added the CLI package #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
requested review from
williamw2,
nicholasrice and
EisenbergEffect
as code owners
janechu
force-pushed
the
users/janechu/add-cli
branch
from
7c46643
to
e0e7ef0
Compare
janechu
force-pushed
the
users/janechu/add-cli
branch
from
e0e7ef0
to
d485424
Compare
janechu
force-pushed
the
users/janechu/add-cli
branch
2 times, most recently
from
87bcfe4
to
7fbec8b
Compare
janechu
force-pushed
the
users/janechu/add-cli
branch
from
7fbec8b
to
88a30fc
Compare
nicholasrice
reviewed
Apr 7, 2022
nicholasrice
reviewed
Apr 7, 2022
nicholasrice
reviewed
Apr 7, 2022
chrisdholt
reviewed
Apr 8, 2022
chrisdholt
approved these changes
Apr 8, 2022
EisenbergEffect
suggested changes
Apr 11, 2022
There was a problem hiding this comment.
Need some explanation for the change in naming patterns. We want to be consistent so if we're going to recommend _ then we should probably match that in our source as well. That said, I haven't seen anyone use this pattern. Most libraries/frameworks use . so I'd like to understand the reasoning for this change better.
EisenbergEffect
approved these changes
Apr 13, 2022
nicholasrice
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Added the CLI package which will install the default package.
🎫 Issues
Closes #3
✅ Checklist
General
⏭ Next Steps