Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stories rule #116

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Added stories rule #116

merged 2 commits into from
Aug 15, 2022

Conversation

janechu
Copy link
Contributor

@janechu janechu commented Aug 12, 2022

Pull Request

📖 Description

This adds a rule to convert *.stories.ts file which are used in storybook.

🎫 Issues

Continued work on #41

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.

@janechu janechu self-assigned this Aug 12, 2022
EisenbergEffect
EisenbergEffect approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the end of this you are basically going to be an eslint and estree expert. 😄

@janechu janechu merged commit 73d40c8 into main Aug 15, 2022
@janechu janechu deleted the users/janechu/add-stories-rule branch August 15, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@williamw2 williamw2 Awaiting requested review from williamw2

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees

@janechu janechu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janechu @EisenbergEffect