Added styles rule #117
Merged
Added styles rule #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
requested review from
williamw2,
nicholasrice and
EisenbergEffect
as code owners
packages/eslint-plugin-fast-cli-migrate/src/rules/1.0.0-alpha.1--styles.md
Outdated
Show resolved
Hide resolved
EisenbergEffect
suggested changes
Aug 15, 2022
janechu
force-pushed
the
users/janechu/add-styles-rule
branch
from
63a0798
to
80b48b9
Compare
EisenbergEffect
approved these changes
Aug 15, 2022
packages/eslint-plugin-fast-cli-migrate/src/rules/1.0.0-alpha.1--styles.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fast-cli-migrate/src/tests/files/1.0.0-alpha.1--styles.valid.ts
Outdated
Show resolved
Hide resolved
…1--styles.md Co-authored-by: Rob Eisenberg <EisenbergEffect@users.noreply.github.com>
…alpha.1--styles.valid.ts Co-authored-by: Rob Eisenberg <EisenbergEffect@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds a rule for
*.styles.tsfiles.🎫 Issues
Continues work on #41
👩💻 Reviewer Notes
This logic has been extracted into a utilities file because the exact same logic will apply to the next PR in this series which will deal with removing the function wrapper of the
*.template.tsfile.✅ Checklist
General