Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved data.props.ts to fast-components-react-msft #2451

Closed
wants to merge 1 commit into from

Conversation

Manan311
Copy link

@Manan311 Manan311 commented Nov 17, 2019

Description

Motivation & context

Issue #2269
I have moved file data.props.ts from fast-component-explorer directory to fast-components-react-msft directory.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@Manan311 Manan311 changed the title moved data.props.ts to fast-components-react-msft chore: moved data.props.ts to fast-components-react-msft Nov 17, 2019
@chrisdholt
Copy link
Member

Thanks @Manan311 for the contribution! I think there's a couple things we'll need to finalize to get this to successfully pass the build. Because the interface is used in the fast-component-explorer package, we'll need it exported - that's why the unit tests are failing. Looks like this issue could've used a bit more detail; I likely should have caught that when adding the label.

Curious if @janechu thinks the /utilities folder is a good place to export simply the interface here?

@janechu
Copy link
Collaborator

janechu commented Nov 18, 2019

@chrisdholt I agree
@Manan311 I think this should be moved to packages/fast-component-explorer/app/utilities/. Per Chris' suggestion, to pass the build you will need to update the imports since the location of the file will be changing, you should be able to find them mostly in the configs folder but they may also exist elsewhere in this package.

@Manan311
Copy link
Author

I totally forgot about changing the paths before I made the pr, so I been working on that and I'll update this and add the updated file again

@stale
Copy link

stale bot commented Nov 24, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Nov 24, 2019
@stale stale bot closed this Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warning:stale No recent activity within a reasonable amount of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants