Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberField inc/dec buttons don't work anymore #5246

Closed
atmgrifter00 opened this issue Oct 1, 2021 · 2 comments 路 Fixed by #5289
Closed

NumberField inc/dec buttons don't work anymore #5246

atmgrifter00 opened this issue Oct 1, 2021 · 2 comments 路 Fixed by #5289
Assignees
@robarbms
Labels
area:fast-foundation Pertains to fast-foundation bug A bug community:request Issues specifically reported by a member of the community. status:needs-investigation Needs additional investigation
Projects
Components

Comments

@atmgrifter00
Copy link
Contributor

atmgrifter00 commented Oct 1, 2021 •
edited

馃悰 Bug Report

I believe a recent change broke the inc/dec buttons of the fast-number-field.

馃捇 Repro or Code Sample

Literally just use @microsoft/fast-foundation@2.16.4 (or later) along with a compatible fast-components version, put a fast-number-field down and try to use the inc/dec buttons. They won't update the value.

馃 Expected Behavior

Pressing the inc/dec buttons should cause the value to update.

馃槸 Current Behavior

The value does not update.

馃拋 Possible Solution

A new displayText field has been added to the NumberField which I believe the template is getting its display text from, yet it isn't updated anywhere except the connectedCallback function, which seems wrong. Why aren't you just updating this in updateValue() (I realize this change came from an outside contributor)?

馃實 Your Environment

Windows Desktop
@microsoft/fast-foundation@2.16.4
@microsoft/fast-components@2.8.3
@atmgrifter00 atmgrifter00 added the status:triage New Issue - needs triage label Oct 1, 2021
@atmgrifter00 atmgrifter00 changed the title fix: [what is the issue?] in [where is the issue?] NumberField inc/dec buttons don't work anymore Oct 1, 2021
@EisenbergEffect EisenbergEffect added area:fast-foundation Pertains to fast-foundation bug A bug community:request Issues specifically reported by a member of the community. status:needs-investigation Needs additional investigation and removed status:triage New Issue - needs triage labels Oct 4, 2021
@EisenbergEffect EisenbergEffect added this to Triage in Components via automation Oct 4, 2021
@atmgrifter00
Copy link
Contributor Author

I'll mention that I have a fix in work for this (along with tests). I don't mind picking up the torch here.

@atmgrifter00 atmgrifter00 mentioned this issue Oct 4, 2021
Closed
9 tasks
@robarbms robarbms self-assigned this Oct 5, 2021
@robarbms robarbms mentioned this issue Oct 5, 2021
Closed
9 tasks
@robarbms robarbms linked a pull request Oct 5, 2021 that will close this issue
fix: number-field increment and decrement don't update display text #5253
Closed
9 tasks
@claviska
Copy link
Contributor

claviska commented Oct 8, 2021

Possibly related: the input is also allowing A-Z as well as 0-9.

@vnbaaij vnbaaij mentioned this issue Oct 12, 2021
Closed
@robarbms robarbms linked a pull request Oct 19, 2021 that will close this issue
fix: number-field range coercion and step constrols #5289
Merged
9 tasks
Components automation moved this from Triage to Done Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robarbms robarbms

Labels
area:fast-foundation Pertains to fast-foundation bug A bug community:request Issues specifically reported by a member of the community. status:needs-investigation Needs additional investigation
Projects
Components
  
Done
Milestone
No milestone
4 participants
@claviska @EisenbergEffect @atmgrifter00 @robarbms