fix: number-field increment and decrement don't update display text #5253
+4,362
−703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robarbms
requested review from
awentzel,
chrisdholt,
EisenbergEffect,
Falkicon,
janechu and
nicholasrice
as code owners
jattasNI
reviewed
Oct 5, 2021
packages/web-components/fast-foundation/src/number-field/number-field.spec.ts
Outdated
Show resolved
Hide resolved
* refactor css custom property emission so that default properties aren't emitted to the body * Change files * remove throw Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com>
* refactor: remove lodash-es as a dependency Fixes #5271 * Change files * fixup! failing test/menu loop * fixup! missing else * Update packages/utilities/fast-web-utilities/src/functions.ts Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com> Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
* add parts to horizontal scroller template * move resize-observer and intersection service to utilities * ccalculate framesPerSecond with requestAnimationFrame in horizontal-scroll * use reducer for updateScrollStops in horizontal-scroll * use optional chaining and conditional operators in horizontal-scroll * ensure fps is determined before setting stepcount * use transforms and transitions instead * Change files * merge move method into scrollToPosition - fix playwright test
…ities (#5277) * remove throttle function from fast-web-utilities - use requestAnimationFrame in fast-animation * fix warning when building webpack in fast-animation * Change files
…5278) * remove prefix from uniqueId function * Change files Co-authored-by: Chris Holt <chhol@microsoft.com>
* Fill color design token update Background color token was renamed as part of this commit 6de6117 but some docs and usage examples still reference the old name * Apply suggestions from code review Co-authored-by: Chris Holt <chhol@microsoft.com>
* add focus event trigger * Change files * combine hover and focus properties * add removeEventListeners for focusin and focusout Co-authored-by: Dexter Lesaca <v-dlesac@microsoft.com> Co-authored-by: Chris Holt <chhol@microsoft.com>
* add data grid row header * Change files * template feedback * prettier Co-authored-by: Chris Holt <chhol@microsoft.com>
* build(fast-element): exclude empty js files from esm index.js * Change files
* Calendar component * small update * Change files * Adding calendar component to storybook * Updating styles, adding tests * Updating stories * Adding more tests * Another test, refactoring RTL * Updating api * Adding definition * Updating styles, adding click examples * Updating api * Fixing default slot * Updating change log, fixing today code * Adding data-grid * Implementing a calendar-grid in fast-calendar * small update * Consolidating styles. * Updating calendar to reflect vNext changes * Implementing custom elements for fast-calendar-grid * Adding date selection events. * Adding better access to parts for customizability * Adding support for disabled and selected dates. * Updating attributes and definitions. * Adding tests for disabled, selected and RTL. * Updating slots. * Cleaning up Calendar api * Updating story styles. * Fixing a bug with event example. * Marking class exports * Adding aria labels to calendar cells. * Adding aria for weekday labels * CSS variable defaults for improved inheritance * Update date format types. * Adding missing attribute to definition. * Breaking date formatting out into it's own file. * Moving grid to foundation * Updating tests * Updating tests * Setting up tests in en-US by default * Removing calendar-cell * Removing the rest of calendar-cell * Removing border radius from data-grid-cells * Removing unused elements * Adding high contrast colors * Fixing no wrap on data-grid-cells * Adding base font color. * Adding readonly calendar * Updating api * Updating calendar styles for use with date-picker * Left aligning slotted content * Updating interactive styles * Adding title during component registeration * Fixing dateFormatter for FireFox * Cleaning up styles * Fixing weekday styles for storybook * Setting date formatting to fromView mode * Updating template documentation * Updating tests for browser date compat Co-authored-by: Chris Holt <chhol@microsoft.com>
* move style assignment for combobox and select into the class and off the DOM node * Change files
|
Thanks for the fix! While testing, I noticed I'm able to type non-numeric characters into the field whereas previous versions didn't allow that. I'm aware that these characters are removed on blur, but it's odd they can be entered at all and this behavior is inconsistent with Can we restore the old behavior by only allowing |
* wire API to configure design token root * remove test from rollup * adding tests * adding deregister test * clean up tests * adding deregister documentation * enable tests * adding await to before/after each * replace missing test case * rename mderegister methods, update docs, and add opt-out feature to DesignSystem to prevent DesignToken registration * Change files * fix ae docs * refactor to remove hard reference to document Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com>
…com/microsoft/fast into users/robarb/number-field-increment
|
I had a bunch of merge conflicts with this PR. I created a new PR: #5289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
When using the increment and decrement arrows to change the value, the displayed value does not update. Also, changing the value through script does not update the displayed value.
🎫 Issues
#5246
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps