Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disabling "selection" for parent node fast-tree-item's with child nodes. #5448

Closed
vogtn opened this issue Dec 7, 2021 · 3 comments
Labels
area:fast-foundation Pertains to fast-foundation closed:obsolete No longer valid status:needs-investigation Needs additional investigation warning:stale No recent activity within a reasonable amount of time

Comments

@vogtn
Copy link

vogtn commented Dec 7, 2021

🙋 Feature Request

We would like to support a tree-view with parent tree-items that are not selectable, but is still able to open and close, w3, to access the child elements and select them instead.

🤔 Expected Behavior

From https://explore.fast.design/components/fast-tree-view

<fast-tree-view>
    <fast-tree-item selectable="false">Tree item 1<fast-tree-item slot="item">Tree item 1 - 1</fast-tree-item>
    </fast-tree-item>
    <fast-tree-item selectable="false">Tree item 2</fast-tree-item>
</fast-tree-view>

😯 Current Behavior

Disabled/Selectable currently affects entire tree.

💁 Possible Solution

Selectable? attribute

🔦 Context

Our implementation example is a "teams-channel-picker", we have teams as the parents, and teams's channels as the child nodes. Teams aren't selectable, but the channels are. See the mgt storybook teams-channel-picker for example functionality.

Disabled functionality doesn't support this, as we still want the child nodes selectable.

💻 Examples

Sample, red is not selectable:
MicrosoftTeams-image

@vogtn vogtn added the status:triage New Issue - needs triage label Dec 7, 2021
@chrisdholt chrisdholt changed the title feat: add disabling "selection" for fast-tree-item feat: add disabling "selection" for parent node fast-tree-item's with child nodes. Dec 7, 2021
@chrisdholt
Copy link
Member

I've updated this issue title to better represent what I think the ask is. From what I've understood from our conversations, currently parent nodes within a tree item (items with child nodes) are selectable and interactive. The one and primary concern I have here (as mentioned offline) is that I'm not sure that can be done in a way that is both standard based and accessible, and so I'm not sure it is something we can for sure add first-party support for.

With that said, I'd like to take the following approach here:

  1. Investigate if this is a standard pattern.

  2. If this is a standard pattern, we can support it. If it's not a standard pattern, is there something we are doing which makes you taking this approach prohibitive AND is that something we can find a way to enable this.

The above leaves room for first party support while at the very least identifying what's preventing it and seeing if there is a way we can enable you accomplishing your goals with this scenario.

@chrisdholt chrisdholt added status:needs-investigation Needs additional investigation area:fast-components area:fast-foundation Pertains to fast-foundation and removed status:triage New Issue - needs triage labels Dec 7, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Apr 16, 2022
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-components has been deprecated for some time.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-foundation Pertains to fast-foundation closed:obsolete No longer valid status:needs-investigation Needs additional investigation warning:stale No recent activity within a reasonable amount of time
Projects
None yet
Development

No branches or pull requests

3 participants