-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: design-system-provider now paints CSS color and background color #3278
Merged
nicholasrice
merged 8 commits into
master
from
users/nirice/add-background-and-color-to-DSP
Jun 11, 2020
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a908a60
wiring and testing behavior
nicholasrice 2381686
add code-comments
nicholasrice de8b376
bring changes over to components-msft
nicholasrice bacf742
pretty pretty
nicholasrice e461f62
update documentation
nicholasrice 7b94efb
Merge branch 'master' into users/nirice/add-background-and-color-to-DSP
nicholasrice dacf350
Merge branch 'master' into users/nirice/add-background-and-color-to-DSP
nicholasrice c014316
Merge branch 'master' into users/nirice/add-background-and-color-to-DSP
nicholasrice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
16 changes: 16 additions & 0 deletions
16
packages/web-components/fast-components-msft/.storybook/preview-head.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<style> | ||
html, | ||
body, | ||
#root { | ||
margin: 0; | ||
display: flex; | ||
flex-direction: column; | ||
height: 100%; | ||
} | ||
|
||
fast-design-system-provider { | ||
flex-grow: 1; | ||
overflow: auto; | ||
padding: calc(var(--design-unit) * 2px); | ||
} | ||
</style> |
5 changes: 5 additions & 0 deletions
5
packages/web-components/fast-components-msft/.storybook/theme.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import { create } from "@storybook/theming/create"; | ||
|
||
export default create({ | ||
brandTitle: "FAST components MSFT storybook", | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 12 additions & 5 deletions
17
packages/web-components/fast-components/.storybook/preview-head.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,16 @@ | ||
<style> | ||
body { | ||
background-color: #181818; | ||
html, | ||
body, | ||
#root { | ||
margin: 0; | ||
display: flex; | ||
flex-direction: column; | ||
height: 100%; | ||
} | ||
|
||
h1, h2, h3, h4, h5, h6 { | ||
color: #FFF; | ||
|
||
fast-design-system-provider { | ||
flex-grow: 1; | ||
overflow: auto; | ||
padding: calc(var(--design-unit) * 2px); | ||
} | ||
</style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,5 @@ | ||
import { create } from "@storybook/theming/create"; | ||
|
||
export default create({ | ||
base: "dark", | ||
colorPrimary: "#DA1A5F", | ||
appContentBg: "#181818", | ||
textColor: "#FFF", | ||
brandTitle: "FAST components storybook", | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍