Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed error in slider story causing issue in slider-label story #3600

Merged
merged 2 commits into from Jul 30, 2020
Merged

fix: fixed error in slider story causing issue in slider-label story #3600

merged 2 commits into from Jul 30, 2020

Conversation

marjonlynch
Copy link
Contributor

Description

name collision where slider-label story is affected by addon channel listener in slider story causing slider-label story to crash

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@marjonlynch marjonlynch self-assigned this Jul 30, 2020
@marjonlynch marjonlynch force-pushed the users/marjon/fix-slider-story branch from 12d1368 to 5617e30 Compare July 30, 2020 21:08
awentzel
awentzel approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@awentzel awentzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, though with suggestions if possible.

@marjonlynch marjonlynch force-pushed the users/marjon/fix-slider-story branch from 85ed996 to ab2dc4b Compare July 30, 2020 21:30
@marjonlynch marjonlynch merged commit ad6e0e9 into master Jul 30, 2020
@marjonlynch marjonlynch deleted the users/marjon/fix-slider-story branch July 30, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@scomea scomea scomea approved these changes

@awentzel awentzel awentzel approved these changes

@khamudom khamudom khamudom approved these changes

@chrisdholt chrisdholt Awaiting requested review from chrisdholt chrisdholt is a code owner

@janechu janechu Awaiting requested review from janechu janechu is a code owner

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees

@marjonlynch marjonlynch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marjonlynch @EisenbergEffect @scomea @awentzel @khamudom