Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hypertext and lightweight display and min-width styles #3708

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

radium-v
Copy link
Collaborator

@radium-v radium-v commented Aug 13, 2020

Description

  • reset min-width on hyperlink anchors and buttons
  • restore display: inline-flex on anchors and buttons

Motivation & context

The switch from inline-flex to inline-block in #3674 caused elements on the homepage to become misaligned.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure...we had a recent fix in anchors I think to address the extra underline at the end. This doesn't regress that fix does it?

@EisenbergEffect EisenbergEffect added this to In Review in Components via automation Aug 13, 2020
- reset `min-width` on hyperlink anchors and buttons
- restore `display: inline-flex` on anchors and buttons
@radium-v radium-v force-pushed the users/jokreitl/anchor-lightweight branch from e3fde20 to e15859d Compare August 13, 2020 16:43
@radium-v
Copy link
Collaborator Author

@EisenbergEffect The original fix didn't identify the underlying cause of the extra underlined space, which is min-width getting applied to hypertext anchors and buttons.

@EisenbergEffect
Copy link
Contributor

Excellent. Thanks @radium-v I really appreciate your skillz 🥇

@radium-v radium-v changed the title fix: hyperlink and lightweight display and min-width styles fix: hypertext and lightweight display and min-width styles Aug 13, 2020
@radium-v radium-v mentioned this pull request Aug 13, 2020
12 tasks
Components automation moved this from In Review to Ready Aug 13, 2020
@radium-v radium-v merged commit 22e904d into master Aug 13, 2020
Components automation moved this from Ready to Done Aug 13, 2020
@radium-v radium-v deleted the users/jokreitl/anchor-lightweight branch August 13, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug
Projects
No open projects
Components
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants