Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct tabs examples in documentation #3935

Merged
merged 2 commits into from Sep 21, 2020

Conversation

nicholasrice
Copy link
Contributor

@nicholasrice nicholasrice commented Sep 21, 2020

Description

Tabs documentation was using a lightweight anchor style in a list of anchors, resulting in a mismatch in visual alignment between list item indicators and the anchor itself. This happens because the lightweight style isn't intended to be used inline in text. This PR replaces the lightweight style with a hypertext style, which is intended to be used inline.

closes #3816

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@nicholasrice nicholasrice added this to the Release 12 milestone Sep 21, 2020
@nicholasrice nicholasrice self-assigned this Sep 21, 2020
@nicholasrice nicholasrice merged commit f200ff9 into master Sep 21, 2020
@nicholasrice nicholasrice deleted the users/nirice/fix-tabs-example branch September 21, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabbed text content when using lists does not align to the text
3 participants