Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update start and end slot to remove fixed width and height #4081

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

khamudom
Copy link
Contributor

Description

On buttons and menu-item, the start and end slots have fixed width and height. This will cause elements larger than 16px to clip.
This PR removes the fixed dimension on the start and end slot but keeps the 16px on the SVG.
I also updated the grid-template-columns property on the menu-item that will also cause clipping with elements that are larger than 42px.
This should not break any current implementation when using a button, anchor, or the menu-item. This will now allow authors to add larger elements to the start and end slots if the design calls for it.

fixes #3904

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@khamudom khamudom self-assigned this Oct 27, 2020
@khamudom khamudom force-pushed the users/khamu/update-start-end-fixed-dimension branch from a34b50d to db6e1d3 Compare October 27, 2020 22:44
@khamudom khamudom force-pushed the users/khamu/update-start-end-fixed-dimension branch from 348e0ab to e0b704a Compare October 29, 2020 18:44
@khamudom khamudom force-pushed the users/khamu/update-start-end-fixed-dimension branch from e0b704a to 50fba0b Compare October 29, 2020 19:44
@khamudom khamudom merged commit 5f267fc into master Oct 29, 2020
@khamudom khamudom deleted the users/khamu/update-start-end-fixed-dimension branch October 29, 2020 20:35
@EisenbergEffect EisenbergEffect added this to In Review in Components via automation Nov 2, 2020
@EisenbergEffect EisenbergEffect moved this from In Review to Done in Components Nov 2, 2020
@EisenbergEffect EisenbergEffect added this to the Release 2020-10 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Components
  
Done
Development

Successfully merging this pull request may close these issues.

mis-aligned slots in fast-menu-item (and fast-button)
5 participants