New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move native definitions to tooling #4607
chore: move native definitions to tooling #4607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd better fill out the titles as that may result in empty labels in the Form
.
packages/tooling/fast-tooling/src/definitions/native/path.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/path.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/path.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/path.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/svg.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/svg.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/svg.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/svg.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/svg.definition.ts
Outdated
Show resolved
Hide resolved
packages/tooling/fast-tooling/src/definitions/native/svg.definition.ts
Outdated
Show resolved
Hide resolved
…nition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…nition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…nition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…nition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
Code Climate has analyzed commit d4920c0 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 78.7% (0.0% change). View more on Code Climate. |
Pull Request
📖 Description
Moving native HTML definitions from sites/site-utilities to packages/tooling/fast-tooling to make them more accessible to other components. Needed for the new html-render component in order to prevent circular dependencies.
After this is completed tests need to be added for html-native.definition.ts. See #4608
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn change
Component-specific
⏭ Next Steps