Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move native definitions to tooling #4607

Merged
merged 15 commits into from Apr 19, 2021

Conversation

williamw2
Copy link
Contributor

@williamw2 williamw2 commented Apr 16, 2021

Pull Request

📖 Description

Moving native HTML definitions from sites/site-utilities to packages/tooling/fast-tooling to make them more accessible to other components. Needed for the new html-render component in order to prevent circular dependencies.
After this is completed tests need to be added for html-native.definition.ts. See #4608

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

Copy link
Collaborator

@janechu janechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd better fill out the titles as that may result in empty labels in the Form.

williamw2 and others added 11 commits April 16, 2021 15:36
…nition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…nition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…nition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…nition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
…ition.ts

Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
@codeclimate
Copy link

codeclimate bot commented Apr 19, 2021

Code Climate has analyzed commit d4920c0 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 78.7% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants