Added boundaries to re-index parameters #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Unit tests
Ivanidzo4ka
reviewed
Jul 20, 2021
| @@ -220,6 +220,11 @@ public override void OnActionExecuted(ActionExecutedContext context) | |||
| } | |||
| } | |||
| } | |||
| else if (context.Exception is ArgumentOutOfRangeException argumentOutOfRangeException) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
BadRequestException makes sense. Another possible option is a new Exception type which extends ArgumentOutOfRange.
Ivanidzo4ka
reviewed
Jul 21, 2021
src/Microsoft.Health.Fhir.Core/Features/Operations/Reindex/Models/ReindexJobRecord.cs
Outdated
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Jul 21, 2021
|
|
||
| set | ||
| { | ||
| if (value < 1 || value > 5000) |
Ivanidzo4ka
reviewed
Jul 21, 2021
|
|
||
| set | ||
| { | ||
| if (value > 10) |
Ivanidzo4ka
reviewed
Jul 21, 2021
Ivanidzo4ka
reviewed
Jul 21, 2021
src/Microsoft.Health.Fhir.Core/Features/Operations/Reindex/Models/ReindexJobRecord.cs
Outdated
Show resolved
Hide resolved
feordin
approved these changes
Jul 21, 2021
apurvabhaleMS
deleted the
personal/apurvabhale/boundaries-on-reindex-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added boundaries to ReIndex parameters
Added Unit tests
Currently, we have below ranges for different parameters based on prior experience. ( discussion with Jared )
MaximumConcurrency: 10
QueryDelayIntervalInMilliseconds: 5 - 500000
MaximumNumberOfResourcesPerQuery: 1 - 5000
TargetDataStoreUsagePercentage: 0 - 100
Related issues
Addresses [#81246].
Testing
Unite Test
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)