Added retry logic while Deleting SearchParameter #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the R5 issue with Priority uint changed to CodeableConcept
…CustomSearchParam-Failing-Unit-Tests
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ts' of https://github.com/microsoft/fhir-server into personal/apurvabhale/CustomSearchParam-Failing-Unit-Tests
…earchParam_WhenUpdatingParam_ThenResourcesIndexedWithUpdatedParam
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ivanidzo4ka
reviewed
Jul 28, 2021
src/Microsoft.Health.Fhir.Core/Features/Search/SearchParameterNotSupportedException.cs
Outdated
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Jul 28, 2021
src/Microsoft.Health.Fhir.Tests.Common/TestFiles/Normative/Appointment.json
Outdated
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Jul 28, 2021
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/CustomSearchParamTests.cs
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Jul 28, 2021
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/CustomSearchParamTests.cs
Outdated
Show resolved
Hide resolved
Reverted Appointment.json
Reverted Appointment.json
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…CustomSearchParam-Failing-Unit-Tests
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbans96
reviewed
Jul 29, 2021
| @@ -175,6 +174,8 @@ public async Task GivenASearchParam_WhenUpdatingParam_ThenResourcesIndexedWithUp | |||
|
|
|||
| // Reindex just a single patient, so we can try searching with a partially indexed search param | |||
| (reindexJobResult, reindexJobUri) = await Client.PostReindexJobAsync(new Parameters(), $"Patient/{expectedPatient.Resource.Id}/"); | |||
| await Task.Delay(10000); | |||
There was a problem hiding this comment.
nit: await Task.Delay(TimeSpan.FromSeconds(10)); for better readability
…CustomSearchParam-Failing-Unit-Tests
This reverts commit 27c4826.
apurvabhaleMS
deleted the
personal/apurvabhale/CustomSearchParam-Failing-Unit-Tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a retry logic while Deleting SearchParameter.
When there are multiple instances of the fhir-server running, it could take some time for the search parameter/reindex updates to propogate to all instances. Hence we are adding some retries below to account for that delay.
Related issues
Addresses [82891].
Testing
Manual Testing
Unit Test
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)