Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log 500's to Request Metric #2240

Merged

Conversation

apurvabhaleMS
Copy link
Contributor

@apurvabhaleMS apurvabhaleMS commented Sep 23, 2021

Description

When any unknown/unhandled error occurs, the context get's updated after the ApiResponseNotification is published. Due to this 500s or any unknown/unhandled errors are not getting logged in RequestMetric.

Related issues

Addresses 81035.

Testing

Test if 500s are getting logged in RequestMetric table

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
  • Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
  • Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@apurvabhaleMS
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@apurvabhaleMS
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@apurvabhaleMS apurvabhaleMS marked this pull request as ready for review October 18, 2021 18:23
@apurvabhaleMS apurvabhaleMS requested a review from a team as a code owner October 18, 2021 18:23
@apurvabhaleMS apurvabhaleMS merged commit a9d9f5a into main Oct 20, 2021
@apurvabhaleMS apurvabhaleMS deleted the personal/apurvabhale/missing-500s-from-requestMetric branch October 20, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants