Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runs patient $everything on "seealso" links #2305

Merged
merged 7 commits into from
Oct 29, 2021

Conversation

rotodd
Copy link
Contributor

@rotodd rotodd commented Oct 28, 2021

Description

Combining PRs #2249, #2257, #2303 and #2282.

This PR merges the patient $everything links feature branch into main. It includes a functionality change to the patient $everything operation, where seealso links are processed after the parent patient's resources are returned (PR #2249). This is set up to only follow seealso links one layer deep, so we do not process a seealso link's seealso links.

The patient $everything operation returns information asynchronously in bundles over the course of multiple API calls. When we check to see which seealso link we should process next (if any), we retrieve the version of the parent patient passed in during the initial patient $everything request. This version check was added in PR #2257.

To avoid a breaking change, PR #2302 implements the ability to use the Prefer header to specify whether replaced-by links are handled in a lenient or strict way, following the same functionality we have setup for other search bundles.

Finally, a minor enhancement to avoid returning empty bundles mid-operation was implemented in PR #2282.

Related issues

Addresses AB#86017.

Testing

Added unit tests, E2E tests and an .http file for manual testing/demos.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • ✅ Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
  • ✅ Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
  • ✅ Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
  • ✅ Review squash-merge requirements

Semver Change (docs)

Feature (feature change)

@rotodd rotodd requested a review from a team as a code owner October 28, 2021 23:27
@rotodd rotodd added this to the S74 milestone Oct 28, 2021
@rotodd rotodd added New Feature Label for a new feature in FHIR OSS Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Oct 28, 2021
Copy link
Member

@brendankowitz brendankowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rotodd rotodd enabled auto-merge (squash) October 29, 2021 22:27
@rotodd rotodd merged commit 9937820 into main Oct 29, 2021
@rotodd rotodd deleted the feature/patient-everything-links branch October 29, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR New Feature Label for a new feature in FHIR OSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants