-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runs patient $everything on "seealso" links #2305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs AB#85562 +semver: feature
src/Microsoft.Health.Fhir.Shared.Core/Extensions/PreferHeaderExtensions.cs
Show resolved
Hide resolved
...Microsoft.Health.Fhir.Shared.Core/Features/Operations/Everything/PatientEverythingService.cs
Outdated
Show resolved
Hide resolved
brendankowitz
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
New Feature
Label for a new feature in FHIR OSS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combining PRs #2249, #2257, #2303 and #2282.
This PR merges the patient $everything links feature branch into main. It includes a functionality change to the patient $everything operation, where
seealso
links are processed after the parent patient's resources are returned (PR #2249). This is set up to only followseealso
links one layer deep, so we do not process aseealso
link'sseealso
links.The patient $everything operation returns information asynchronously in bundles over the course of multiple API calls. When we check to see which
seealso
link we should process next (if any), we retrieve the version of the parent patient passed in during the initial patient $everything request. This version check was added in PR #2257.To avoid a breaking change, PR #2302 implements the ability to use the
Prefer
header to specify whetherreplaced-by
links are handled in a lenient or strict way, following the same functionality we have setup for other search bundles.Finally, a minor enhancement to avoid returning empty bundles mid-operation was implemented in PR #2282.
Related issues
Addresses AB#86017.
Testing
Added unit tests, E2E tests and an .http file for manual testing/demos.
FHIR Team Checklist
Semver Change (docs)
Feature (feature change)