Matched resources should not also be _included #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankowitz
force-pushed
the
personal/bkowitz/bug-2037
branch
from
03056c7
to
d4bd7bf
Compare
brendankowitz
force-pushed
the
personal/bkowitz/bug-2037
branch
from
3ba627c
to
8446bcd
Compare
brendankowitz
changed the title
brendankowitz
added
Azure API for FHIR
brendankowitz
force-pushed
the
personal/bkowitz/bug-2037
branch
from
8446bcd
to
37562b8
Compare
brendankowitz
force-pushed
the
personal/bkowitz/bug-2037
branch
from
37562b8
to
e2ff59e
Compare
LTA-Thinking
reviewed
Feb 2, 2022
| [InlineData("_include")] | ||
| [InlineData("_revinclude")] | ||
| [Theory] | ||
| public async Task GivenAnIncludeSearchExpressionWithLocationLinkedToItself_WhenSearched_ThenCorrectBundleShouldBeReturned(string includeType) |
There was a problem hiding this comment.
Would a test showing that this also works for cyclical references have value? IE: resource 1 references resource 2 and resource 2 references resource 1.
There was a problem hiding this comment.
Good idea, I think this can only be done with SQL (:iterate)
LTA-Thinking
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a filter so that if a resource is in the "matched" set of results, it should not also be there as an "include".
Limitation: this is only for the current page, it doesn't guarantee uniqueness across pages.
Related issues
Addresses #2037.
Testing
Adds E2E tests
FHIR Team Checklist
Semver Change (docs)
Patch (bug)