Move Bundle notification to Core #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotodd
approved these changes
Feb 10, 2022
src/Microsoft.Health.Fhir.Core/Features/Resources/Bundle/BundleMetricsNotification.cs
Show resolved
Hide resolved
| { | ||
| FhirOperation = bundleType == BundleType.Batch ? AuditEventSubType.Batch : AuditEventSubType.Transaction; | ||
| FhirOperation = bundleType; |
There was a problem hiding this comment.
As discussed, this logic has been moved to BundleHandler.cs since the Hl7.Fhir.Model package is version dependent.
|
|
||
| namespace Microsoft.Health.Fhir.Api.Features.Resources.Bundle | ||
| namespace Microsoft.Health.Fhir.Core.Features.Resources.Bundle |
There was a problem hiding this comment.
To document my learnings: BundleMetricsNotification now lives in a new namespace, which requires us to explicitly indicate that resources are being referenced from Core.Resource and not Core.Features.Resource. No string resources have been moved - this PR clears up the ambiguity that comes with this namespace change.
|
Changing to merge to main as hotfix was determined to be unnecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hotfix to move bundle notification to core. Do not merge the PR.
With the introduction of the Resource.Bundle namespace to Core the Resource references to the string resources file had to be made more explicit.
Related issues
Addresses Bug 88575: Move Bundle Meter Notification to Core
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)