Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding handling for SqlTruncate errors #2553

Merged

Conversation

v-mserdar
Copy link
Contributor

@v-mserdar v-mserdar commented Apr 12, 2022

Description

Adding a check for SqlTruncate Exceptions and tests. In particular this will catch SqlTruncate exceptions for Decimal type based on the specified precision and scale.

The following additional file changes were made based on IDE errors.

Error SA1601 Partial elements should be documented
test/Microsoft.Health.Fhir.R4.Tests.Integration/Persistence/FhirStorageTests.cs
test/Microsoft.Health.Fhir.R5.Tests.Integration/Persistence/FhirStorageTests.cs
test/Microsoft.Health.Fhir.Stu3.Tests.Integration/Persistence/FhirStorageTests.cs

Error IDE0005 Using directive is unnecessary.
src/Microsoft.Health.Fhir.Core/Configs/CoreFeatureConfiguration.cs
src/Microsoft.Health.Fhir.Core/Models/ModelInfoProvider.cs
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Bundle/FhirTransactionFailedExceptionTests.cs

Related issues

Addresses 85267.

Testing

Added new tests to catch these types of exceptions.
Ran the following tests:
Microsoft.Health.Fhir.Azure.UnitTests
Microsoft.Health.Fhir.Core.UnitTests
Microsoft.Health.Fhir.SqlServer.UnitTests

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
  • Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
  • Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
  • CI is green before merge
  • Review squash-merge requirements

Refs AB#85267
+semver: patch

@v-mserdar v-mserdar added the Bug Bug bug bug. label Apr 12, 2022
@v-mserdar v-mserdar requested a review from a team as a code owner April 12, 2022 18:02
@v-mserdar v-mserdar enabled auto-merge (squash) April 12, 2022 20:34
@PTaladay PTaladay added this to the S86 milestone Apr 14, 2022
@v-mserdar v-mserdar merged commit c478ee4 into main Apr 14, 2022
@v-mserdar v-mserdar deleted the personal/v-mserdar/85267_sqltruncate_exception_handling branch April 14, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants