-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation added for Target resource type for include and revinclude search options #2776
Merged
rajithaalurims
merged 9 commits into
main
from
personal/rajithaaluri/revIncludevalidtion76141
Sep 1, 2022
Merged
Validation added for Target resource type for include and revinclude search options #2776
rajithaalurims
merged 9 commits into
main
from
personal/rajithaaluri/revIncludevalidtion76141
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/revIncludevalidtion76141
rbans96
reviewed
Aug 30, 2022
src/Microsoft.Health.Fhir.Shared.Core/Features/Search/SearchOptionsFactory.cs
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/IncludeSearchTests.cs
Outdated
Show resolved
Hide resolved
…/revIncludevalidtion76141
…/revIncludevalidtion76141
rbans96
reviewed
Aug 31, 2022
src/Microsoft.Health.Fhir.Shared.Core/Features/Search/SearchOptionsFactory.cs
Show resolved
Hide resolved
rbans96
reviewed
Aug 31, 2022
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/IncludeSearchTests.cs
Outdated
Show resolved
Hide resolved
rbans96
reviewed
Sep 1, 2022
rbans96
previously approved these changes
Sep 1, 2022
rbans96
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invalid Target resource type was not handled when search with "include" and "revinclude" options.
Related issues
76141
Testing
Test 1:
Test URL : Patient/?revinclude=Observation:subject:NotAResourceType
Returned below error:
"issue": [
{
"severity": "error",
"code": "not-supported",
"diagnostics": "Resource type 'NotAResourceType' is not supported.'."
}
]
Test 2:
Test URL : Patient/?include=Observation:subject:NotAResourceType
Returned below error:
"issue": [
{
"severity": "error",
"code": "not-supported",
"diagnostics": "Resource type 'NotAResourceType' is not supported.'."
}
]
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)