Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation added for Target resource type for include and revinclude search options #2776

Merged
merged 9 commits into from
Sep 1, 2022

Conversation

rajithaalurims
Copy link
Contributor

Description

Invalid Target resource type was not handled when search with "include" and "revinclude" options.

Related issues

76141

Testing

Test 1:
Test URL : Patient/?revinclude=Observation:subject:NotAResourceType
Returned below error:
"issue": [
{
"severity": "error",
"code": "not-supported",
"diagnostics": "Resource type 'NotAResourceType' is not supported.'."
}
]

Test 2:
Test URL : Patient/?include=Observation:subject:NotAResourceType
Returned below error:
"issue": [
{
"severity": "error",
"code": "not-supported",
"diagnostics": "Resource type 'NotAResourceType' is not supported.'."
}
]

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
  • Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
  • Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
  • CI is green before merge
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@rajithaalurims rajithaalurims added the Bug Bug bug bug. label Aug 29, 2022
@rajithaalurims rajithaalurims added this to the S96 milestone Aug 29, 2022
@rajithaalurims rajithaalurims marked this pull request as ready for review August 29, 2022 18:00
@rajithaalurims rajithaalurims requested a review from a team as a code owner August 29, 2022 18:00
rbans96
rbans96 previously approved these changes Sep 1, 2022
@rajithaalurims rajithaalurims merged commit 78e9a52 into main Sep 1, 2022
@rajithaalurims rajithaalurims deleted the personal/rajithaaluri/revIncludevalidtion76141 branch September 1, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants