-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation added to include _text search parameter in UnSupportedParameters List #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Health.Fhir.Shared.Core/Features/Search/SearchOptionsFactory.cs
Outdated
Show resolved
Hide resolved
For my understanding, if Prefer header is not present, then the server is supposed to behave as Prefer:lineant? Not sure if we should add a test for default behavior? |
src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Search/SearchOptionsFactoryTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/BasicSearchTests.cs
Outdated
Show resolved
Hide resolved
You are right. I added another test case to verify that behavior. |
rbans96
previously approved these changes
Aug 30, 2022
LTA-Thinking
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a Resource XXX is searched using _text parameter, we need to throw an error/warning depending on "Prefer handling" header option with a message "The search parameter '_text' is not supported for resource type 'XXX'."
Related issues
82463
Testing
Test 1:
https://localhost:44348/Observation?_text=MOBILE with heading Prefer: handling:strict
Returns below error message:
"issue": [
{
"severity": "error",
"code": "invalid",
"diagnostics": "The search parameter '_text' is not supported for resource type 'Patient'."
}
]
Test 2:
https://localhost:44348/Observation?_text=MOBILE with heading Prefer: handling:lenient
Returns below warning message:
"resource": {
"resourceType": "OperationOutcome",
"id": "004ba8ef-470c-4ee5-9a72-6fe48e5f7069",
"issue": [
{
"severity": "warning",
"code": "not-supported",
"diagnostics": "The search parameter '_text' is not supported for resource type 'Patient'."
}
]
},
In both scenarios, _text is removed from Self URL in the response.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)