fix to handle chained contains query #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-mserdar
added
Bug
v-mserdar
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fhibf
reviewed
Dec 21, 2022
| @@ -6,6 +6,9 @@ | |||
| <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder> | |||
| <IsTestProject>false</IsTestProject> | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
There was a problem hiding this comment.
Curious why this is the only file under "remove".
There was a problem hiding this comment.
Fixed in latest commit
fhibf
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This revision will handle the scenario that previously caused the generated sql to incorrectly join on the wrong columns. See the related item for the specifics.
Related issues
Addresses issue #97812.
Testing
I ran all tests as well as created a new test to handle this scenario
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)