95587: handled not modifier for chained expressions #3041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Service returns 500 error when a not modifier is used with chained expressions.
Related issues
Addresses [issue #95587].
Testing
Creating data
Created two devices with different device type codes. 861840031 and 86184003.
Created two Observation. Once with device type 861840031 and another one with device type 86184003.
Tests
https://localhost:44348/Observation?device:Device.type:not=861840031 - Returned Observation that has Device.type 86184003.
https://localhost:44348/Observation?device:Device.type:not=86184003 - Returned Observation that has Device.type 861840031
https://localhost:44348/Observation?device:Device.type:not=aaa - Returned both Observations I created above.
https://localhost:44348/Observation?device:Device.type=aaa - No Observations returned
https://localhost:44348/Observation?device:Device.type=86184003 - Returned One observation with correct type
https://localhost:44348/Observation?device:Device.type=861840031 - Returned One observation with correct type
https://localhost:44348/Device?type=86184003 - Returned Device with specified type.
https://localhost:44348/Device?type:not=86184003 - Returned Devices that have no type and also device with type not equals to specified value
https://localhost:44348/HealthcareService?_has:PractitionerRole:service:active:not=false - Returned success response but no data as expected.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)