Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

95587: handled not modifier for chained expressions #3041

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

rajithaalurims
Copy link
Contributor

@rajithaalurims rajithaalurims commented Dec 29, 2022

Description

Service returns 500 error when a not modifier is used with chained expressions.

Related issues

Addresses [issue #95587].

Testing

Creating data
Created two devices with different device type codes. 861840031 and 86184003.
Created two Observation. Once with device type 861840031 and another one with device type 86184003.
Tests
https://localhost:44348/Observation?device:Device.type:not=861840031 - Returned Observation that has Device.type 86184003.
https://localhost:44348/Observation?device:Device.type:not=86184003 - Returned Observation that has Device.type 861840031
https://localhost:44348/Observation?device:Device.type:not=aaa - Returned both Observations I created above.
https://localhost:44348/Observation?device:Device.type=aaa - No Observations returned
https://localhost:44348/Observation?device:Device.type=86184003 - Returned One observation with correct type
https://localhost:44348/Observation?device:Device.type=861840031 - Returned One observation with correct type
https://localhost:44348/Device?type=86184003 - Returned Device with specified type.
https://localhost:44348/Device?type:not=86184003 - Returned Devices that have no type and also device with type not equals to specified value
https://localhost:44348/HealthcareService?_has:PractitionerRole:service:active:not=false - Returned success response but no data as expected.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
  • Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
  • Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@rajithaalurims rajithaalurims added Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Dec 29, 2022
@rajithaalurims rajithaalurims added this to the S105 milestone Dec 29, 2022
@rajithaalurims rajithaalurims requested a review from a team as a code owner December 29, 2022 21:03
@rajithaalurims rajithaalurims added Bug Bug bug bug. and removed Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Dec 29, 2022
@rajithaalurims rajithaalurims merged commit 2a54654 into main Jan 3, 2023
@rajithaalurims rajithaalurims deleted the personal/rajithaaluri/chained_not_mdofier branch January 3, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants