Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchParamStatusManager should update datetime after DB write #3222

Merged
merged 1 commit into from Apr 11, 2023

Conversation

feordin
Copy link
Contributor

@feordin feordin commented Apr 11, 2023

Description

We had a customer issue where the FHIR service would not load the latest SearchParameter status. Looking into the logs there were some transient network issues which prevented writing/reading from the database temporarily.

Looking into the code, we were updating the last successfull read/write of the search parameter status before sync'ing to the DB. In the event of a database failure, the in memory datetime would be out of sync with the database. This is a small PR to write the DB first. In the event of a failure, the status will be sync'd on the next attempt.

Related issues

Addresses [issue AB#101603].

Testing

Reran existing test suite.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@feordin feordin requested a review from a team as a code owner April 11, 2023 16:17
@feordin feordin added the Bug Bug bug bug. label Apr 11, 2023
@feordin feordin added this to the 112 milestone Apr 11, 2023
@feordin feordin added Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Apr 11, 2023
@feordin feordin changed the title SearchParameterStatusManager should update datetime after DB write SearchParamStatusManager should update datetime after DB write Apr 11, 2023
@feordin feordin merged commit 853df9f into main Apr 11, 2023
7 of 12 checks passed
@feordin feordin deleted the personal/jaerwin/101603 branch April 11, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants