Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: URL under Capability Statement not Absolute Uri #3265

Merged
merged 3 commits into from May 1, 2023

Conversation

abiisnn
Copy link
Contributor

@abiisnn abiisnn commented Apr 28, 2023

Description

Fix FHIR specification issue.
Capability statement : The url value in the structure definition needs to be absolute uri.

Link to official docs.

Related issues

Addresses [issue #].

Testing

  1. Access the /metadata endpoint on your FHIR Server
  2. Check the Url property -- this should be an absolute url

Before

{
    "resourceType": "CapabilityStatement",
    "url": "/metadata",
    "version": "1.0.0.0",
    "name": "Microsoft FHIR Server for Azure 1.0.0 Capability Statement",
    // ....
}

After

{
    "resourceType": "CapabilityStatement",
    "url": "https://localhost:44348/metadata",
    "version": "1.0.0.0",
    "name": "Microsoft FHIR Server for Azure 1.0.0 Capability Statement",
    // ....
}

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@abiisnn abiisnn added this to the S113 milestone Apr 28, 2023
@abiisnn abiisnn added Bug Bug bug bug. Open source This change is only relevant to the OSS code or release. labels Apr 28, 2023
@abiisnn abiisnn marked this pull request as ready for review May 1, 2023 23:06
@abiisnn abiisnn requested a review from a team as a code owner May 1, 2023 23:06
@PTaladay PTaladay merged commit 05f5275 into main May 1, 2023
8 checks passed
@PTaladay PTaladay deleted the abiisnn/url_under_capability_statement branch May 1, 2023 23:26
@abiisnn abiisnn mentioned this pull request May 2, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants