Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _include bug #3525

Merged
merged 1 commit into from Sep 18, 2023
Merged

Fix _include bug #3525

merged 1 commit into from Sep 18, 2023

Conversation

LTA-Thinking
Copy link
Collaborator

@LTA-Thinking LTA-Thinking commented Sep 18, 2023

Description

Fixes a bug in _include/_revinclude where the following can happen:

  1. Makes request with _include/_revinclude
  2. The max count is set to 200 for the include search.
  3. Include search returns EXACTLY 100 results and a continuation token. This can only happen with multiple partitions and the right data distribution.
  4. The search tries to run again with a max count of 0, which throws an exception.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@LTA-Thinking LTA-Thinking requested a review from a team as a code owner September 18, 2023 18:53
@LTA-Thinking LTA-Thinking added this to the S124 milestone Sep 18, 2023
@LTA-Thinking LTA-Thinking added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Sep 18, 2023
@LTA-Thinking LTA-Thinking merged commit 431181c into main Sep 18, 2023
7 of 10 checks passed
@LTA-Thinking LTA-Thinking deleted the personal/rojo/revinclude-bug branch September 18, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants