Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bundle] Parallel bundle perf improvements #3727

Merged
merged 3 commits into from
Mar 1, 2024
Merged

[Bundle] Parallel bundle perf improvements #3727

merged 3 commits into from
Mar 1, 2024

Conversation

fhibf
Copy link
Contributor

@fhibf fhibf commented Feb 27, 2024 •
edited
Loading

Description

Improving the performance of parallel bundles given most recent performance tests.
From what it was found, changes made are:

  • Replacing call to Task.WaitAll to Task.WhenAll.
  • Removing the explicit GC call as it was causing performance issues, and it's no more required.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@fhibf fhibf requested a review from a team as a code owner February 27, 2024 23:32
@fhibf fhibf added this to the S135 milestone Feb 29, 2024
@fhibf fhibf added Enhancement Enhancement on existing functionality. Bug-Performance Performance related bugs. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Feb 29, 2024
@SergeyGaluzo
Copy link
Contributor 

                // The following Task.WaitAll should wait for all requests to finish.

Please replace by WhenAll

Refers to: src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandlerParallelOperations.cs:143 in fdcf5bf. [](commit_id = fdcf5bf, deletion_comment = False)

SergeyGaluzo
SergeyGaluzo previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@SergeyGaluzo SergeyGaluzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

SergeyGaluzo
SergeyGaluzo approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@SergeyGaluzo SergeyGaluzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fhibf fhibf merged commit 5a96218 into main Mar 1, 2024
43 checks passed
@fhibf fhibf deleted the personal/fhibf/parallelBundleImprovements branch March 1, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankowitz brendankowitz brendankowitz approved these changes

@SergeyGaluzo SergeyGaluzo SergeyGaluzo approved these changes

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug-Performance Performance related bugs. Enhancement Enhancement on existing functionality.
Projects
None yet
Milestone
S135
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fhibf @SergeyGaluzo @brendankowitz