Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Import SurrogateId Collision #3768

Merged
merged 4 commits into from Mar 22, 2024
Merged

Fix Import SurrogateId Collision #3768

merged 4 commits into from Mar 22, 2024

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Mar 22, 2024 •
edited by azure-boards bot

Description

Update MergeResource.sql retry detection logic to take into account resource id & version id (not just surrogate id). This is needed for imports with the same lastUpdated datetimes across multiple ImportProcessingJobs .

Related issues

AB#117953

Testing

Tested locally w/ data that was causing import issues.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner March 22, 2024 05:53
@mikaelweave mikaelweave added Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. Area-Sql-SchemaMigration This PR/Issue includes a schema migration. Schema Version backward compatible labels Mar 22, 2024
SergeyGaluzo
SergeyGaluzo approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@SergeyGaluzo SergeyGaluzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rajithaalurims rajithaalurims added this to the S137 milestone Mar 22, 2024
@rajithaalurims rajithaalurims merged commit 8c33506 into main Mar 22, 2024
48 of 50 checks passed
@rajithaalurims rajithaalurims deleted the personal/mikaelw/import-lastupdate-collision branch March 22, 2024 15:47
@evachen96 evachen96 mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyGaluzo SergeyGaluzo SergeyGaluzo approved these changes

@rajithaalurims rajithaalurims rajithaalurims approved these changes

Assignees
No one assigned
Labels
Area-Sql-SchemaMigration This PR/Issue includes a schema migration. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. Schema Version backward compatible
Projects
None yet
Milestone
S137
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikaelweave @SergeyGaluzo @rajithaalurims