Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky History Test #3887

Merged
merged 5 commits into from
May 30, 2024
Merged

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented May 30, 2024

Description

The test GivenTestResourcesWithUpdatesAndDeletes_WhenGettingResourceHistoryCount_TheServerShouldReturnCorrectCount is behaving flakily and blocking PRs from executing for others devs. Changing the way it finds history for more reliability.

Related issues

AB#121007

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner May 30, 2024 17:42
@mikaelweave mikaelweave added Open source This change is only relevant to the OSS code or release. Bug Bug bug bug. labels May 30, 2024
@mikaelweave mikaelweave added this to the S142 milestone May 30, 2024
SergeyGaluzo
SergeyGaluzo previously approved these changes May 30, 2024
SergeyGaluzo
SergeyGaluzo previously approved these changes May 30, 2024
@mikaelweave mikaelweave merged commit bec76c4 into main May 30, 2024
47 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/flaky-history-test branch May 30, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants