Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report half-blank - CommitmentDiscounts.pbix - FinOps hubs 0.2.1-rc2 #585

Closed
psilantropy opened this issue Feb 6, 2024 · 6 comments 路 Fixed by #595
Closed

Report half-blank - CommitmentDiscounts.pbix - FinOps hubs 0.2.1-rc2 #585

psilantropy opened this issue Feb 6, 2024 · 6 comments 路 Fixed by #595
Assignees
Labels
Area: Power BI Power BI reports Type: Bug 馃悰 Something isn't working

Comments

@psilantropy
Copy link

psilantropy commented Feb 6, 2024

馃悰 Problem

TODO: After redeploying FinOps hubs 0.2.1-rc2 from HERE.
Then downloading the new CommitmentDiscounts.pbix from HERE

I am left with a half-blank report. Only Purchases and Hybrid Benefit have data present. Other tags don't have the subscriptions/services etc.

馃懀 Repro steps

1: Open CommitmentDiscounts.pbix
2. Enter transform data.
3. Open CM connector: scope (must enter scope here even though I use hub)
4. CM connector: number of months - set to 2.
5. FinOps Hubs - Storage URL - update to my deployment hub output URL.
6. Update Rangestart and range end to 01/12/23 - 31/01/2024
7. CLOSE AND APPLY

All queries loading successfully. No error presented.

Click Commitments, loading icons turn, no data presented. (BLANK)
Cannot select date range in the Commitment tab.

All other tabs up to Purchases are blank.
In purchases I can only select current month. All other days are unselectable.
image

Go back to Commitments tab, only FROM date is now present. However I can now select any date (even back before my exports are present). This doesn't change the blank data however.

鈩癸笍 Additional context

If I enter the CostDetails query - I do get data here. A lot of nulls but important items like effective cost, usage quantity are populated.

image

RecommendationsSingle - blank
RecommendationsShared - blank
InstantSizeFlexibility - populated ok

@psilantropy psilantropy added Needs: Triage 馃攳 Untriaged issue needs to be reviewed Type: Bug 馃悰 Something isn't working labels Feb 6, 2024
@psilantropy
Copy link
Author

For reference, the CostSummary.pbix report looks ok (I feel some months look wrong, but cannot confirm yet).

Commitments Tab doesn't look great however;
Commitments

@flanakin
Copy link
Contributor

flanakin commented Feb 9, 2024

@psilantropy I was just coming here to file a bug that was reported where the table is empty. There's a PricingCategory filter in the Commitment discounts report that was set wrong. The fix is easy. Just edit the filter to filter on Commitment-Based instead of Commitment Discount.

You'll need to apply it to the following pages:

  • Commitments
  • Savings
  • Chargeback
  • Prices

I'm about to submit a PR. I'll associate it with this issue for now but please let me know if that's the issue you're running into.

@flanakin flanakin added Area: Power BI Power BI reports Solution: FinOps hubs Data pipeline solution and removed Needs: Triage 馃攳 Untriaged issue needs to be reviewed Solution: FinOps hubs Data pipeline solution labels Feb 9, 2024
@flanakin
Copy link
Contributor

flanakin commented Feb 9, 2024

@all-contributors please add @psilantropy for bug

Copy link
Contributor

@flanakin

I've put up a pull request to add @psilantropy! 馃帀

Copy link
Contributor

@flanakin

@psilantropy already contributed before to bug

@psilantropy
Copy link
Author

psilantropy commented Feb 12, 2024

I'm about to submit a PR. I'll associate it with this issue for now but please let me know if that's the issue you're running into.

Sorry was away a few days. Yes that was exactly the issue and your filter change results in data now. Thank you :).

However, now I see the commitments data - Savings plan data results in an incorrect savings calculation.

image

This is the same result I get from the Azure Savings Dashboard when using amortized csv exports. So maybe I have something strange going on here.

This issue is in any tab that includes Savings Plan.

Edit: This is actually present for reservations also under Commitments tab.
Commitment savings in the table is 0.00 whereas the visual element says 2.95E-14.

@flanakin example;
data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Power BI Power BI reports Type: Bug 馃悰 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants