-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract New-ResourceGroup private command for reuse #656
Open
flanakin
wants to merge
2
commits into
dev
Choose a base branch
from
flanakin/dev/ps-newrg
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111
β38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
requested review from
arthurclares,
didayal-msft,
saadmsft,
Springstone and
sebassem
March 27, 2024 15:28
microsoft-github-policy-service
bot
added
the
Area: PowerShell
PowerShell scripts and automation
label
Mar 27, 2024
microsoft-github-policy-service
bot
assigned aromano2, arthurclares, didayal-msft, saadmsft, Springstone and sebassem
Mar 27, 2024
microsoft-github-policy-service
bot
added
the
Needs: Review π
PR that is ready to be reviewed
label
Mar 27, 2024
flanakin
commented
May 22, 2024
flanakin
commented
May 22, 2024
Comment on lines
+8
to
+14
.EXAMPLE | ||
New-ResourceGroup -WhatIf | ||
|
||
Shows what would happen if the command runs without actually running it. | ||
|
||
.DESCRIPTION | ||
The New-ResourceGroup command performs any initialization tasks required for a resource group contributor to be able to deploy a FinOps hub instance in Azure, like registering resource providers. To view the full list of tasks performed, run the command with the -WhatIf option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
.EXAMPLE | |
New-ResourceGroup -WhatIf | |
Shows what would happen if the command runs without actually running it. | |
.DESCRIPTION | |
The New-ResourceGroup command performs any initialization tasks required for a resource group contributor to be able to deploy a FinOps hub instance in Azure, like registering resource providers. To view the full list of tasks performed, run the command with the -WhatIf option. | |
.DESCRIPTION | |
The New-ResourceGroup command performs any initialization tasks required for a resource group contributor to be able to deploy a FinOps hub instance in Azure, like registering resource providers. To view the full list of tasks performed, run the command with the -WhatIf option. | |
.EXAMPLE | |
New-ResourceGroup -WhatIf | |
Shows what would happen if the command runs without actually running it. |
flanakin
commented
May 22, 2024
.SYNOPSIS | ||
Creates a new resource group. | ||
|
||
.EXAMPLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add parameters to the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: PowerShell
PowerShell scripts and automation
Needs: Review π
PR that is ready to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π οΈ Description
Extract the new RG creation from Deploy-FinOpsHub to reuse in other commands.
π Checklist
π¬ How did you test this change?
πββοΈ Do any of the following that apply?
π Did you update
docs/changelog.md
?π Did you update documentation?