Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup #659

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Test cleanup #659

merged 2 commits into from
Mar 28, 2024

Conversation

flanakin
Copy link
Contributor

πŸ› οΈ Description

  • Get-AzContext seems to have an extra Name property (or we've always had a bug πŸ˜•)
  • Split toolkit unit tests into separate files
  • Fix Save-FinOpsHubTemplate tests
  • Auto-discover private tests

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Yes (required for dev PRs)
  • ➑️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

@flanakin flanakin added this to the 0.2.1 milestone Mar 28, 2024
@flanakin flanakin requested review from aromano2 and a team as code owners March 28, 2024 06:29
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Mar 28, 2024
@flanakin flanakin merged commit 4c54a19 into dev Mar 28, 2024
1 check passed
@flanakin flanakin deleted the flanakin/dev/tests-cleanup branch March 28, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant