Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

RTL mode does not work properly #24

Closed
bmdalex opened this issue Jul 30, 2018 · 0 comments · Fixed by #34
Closed

RTL mode does not work properly #24

bmdalex opened this issue Jul 30, 2018 · 0 comments · Fixed by #34
Assignees
@miroslavstastny

Comments

@bmdalex
Copy link
Collaborator

bmdalex commented Jul 30, 2018

RTL mode does not work properly

Steps

  1. add marginRight: <some_value> style to any component implementation
  2. add a docs example that takes this component
  3. press the RTL button
    screen shot 2018-07-30 at 15 46 56
  4. inspect the component

Expected Result

CSS prop marginRight: <some_value> is changed to marginLeft: <some_value>

Actual Result

CSS marginRight: <some_value> does not change to marginLeft!

Version

0.2.3
@miroslavstastny miroslavstastny self-assigned this Jul 30, 2018
miroslavstastny added a commit that referenced this issue Aug 1, 2018
@miroslavstastny
fix(doc): Use correct LTR/RTL Fela renderer in renderComponent
4b650bd 
fixes #24
@miroslavstastny miroslavstastny mentioned this issue Aug 1, 2018
Merged
1 task
miroslavstastny added a commit that referenced this issue Aug 1, 2018
@miroslavstastny
fix(doc): Use correct LTR/RTL Fela renderer in renderComponent (#34)
4dabc1b 
* fix(doc): Use correct LTR/RTL Fela renderer in renderComponent

fixes #24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miroslavstastny miroslavstastny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(doc): Use correct LTR/RTL Fela renderer in renderComponent microsoft/fluent-ui-react
2 participants
@bmdalex @miroslavstastny