This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Menu): add prop interfaces #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
levithomason,
miroslavstastny and
mnajdova
as code owners
19 tasks
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 68.03% 67.68% -0.35%
==========================================
Files 101 101
Lines 1364 1371 +7
Branches 263 272 +9
==========================================
Hits 928 928
- Misses 434 441 +7
Partials 2 2
Continue to review full report at Codecov.
|
src/components/Menu/Menu.tsx
Outdated
| iconOnly?: boolean | ||
| items?: ItemShorthand[] | ||
| pills?: boolean | ||
| pointing?: boolean |
There was a problem hiding this comment.
once #123 is merged, pointing?: boolean | 'start' | 'end'
src/components/Menu/MenuItem.tsx
Outdated
| index?: number | ||
| onClick?: ComponentEventHandler<IMenuItemProps> | ||
| pills?: boolean | ||
| pointing?: boolean |
miroslavstastny
approved these changes
Aug 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces props interface for Menu and MenuItem components, as part of #117