This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Provider): Honor disableAnimations #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
layershifter,
levithomason and
mnajdova
as code owners
miroslavstastny
commented
Nov 4, 2019
| @@ -24,16 +24,17 @@ export default () => { | |||
| return Object.keys(styles).reduce((acc, cssPropertyName) => { | |||
| const cssPropertyValue = styles[cssPropertyName] | |||
|
|
|||
| if (animationProps.indexOf(cssPropertyName) !== -1) { | |||
There was a problem hiding this comment.
We want to remove animationProps even if they are objects.
mnajdova
reviewed
Nov 5, 2019
| @@ -231,6 +231,7 @@ const renderComponent = <P extends {}>( | |||
| const direction = rtl ? 'rtl' : 'ltr' | |||
| const felaParam = { | |||
| theme: { direction }, | |||
| disableAnimations, | |||
There was a problem hiding this comment.
We have check in the plugin for this:
if (props && props.disableAnimations && type === 'RULE')
Do we really need this one here too?
There was a problem hiding this comment.
But the felaParam here is the props in the plugin. That was the cause of the issue.
We originally passed or params to fela but that changed in #1957 and it caused this bug.
There was a problem hiding this comment.
Got it! Thanks for the clarification
mnajdova
approved these changes
Nov 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2086