Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(SplitButton): Updating splitButton component to match Teams redlines #2108

Merged
merged 41 commits into from
Jan 7, 2020
Merged

fix(SplitButton): Updating splitButton component to match Teams redlines #2108

merged 41 commits into from
Jan 7, 2020

Conversation

notandrew
Copy link
Member

@notandrew notandrew commented Nov 12, 2019 •
edited

Updating the split button layout to match the Teams redlines:

before:
image

after:
image

before:
image

after:

image

new:
image

@notandrew notandrew added redlines Update of the redlines for the mentioned component teams theme 💅 styling issue 🚧 WIP labels Nov 12, 2019
@notandrew notandrew marked this pull request as ready for review November 19, 2019 00:06
@notandrew notandrew changed the title updating splitbutton fix(SplitButton): Updating splitButton component to match Teams redlines Nov 19, 2019
silviuaavram
silviuaavram suggested changes Nov 21, 2019
View reviewed changes
Copy link
Collaborator

@silviuaavram silviuaavram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the styles! Please take a look at the other comments as well, especially the a11y one.

packages/react/src/components/SplitButton/SplitButton.tsx Outdated Show resolved Hide resolved
packages/react/src/components/SplitButton/SplitButton.tsx Outdated Show resolved Hide resolved
docs/src/examples/components/SplitButton/Types/SplitButtonExampleSmall.shorthand.tsx Outdated Show resolved Hide resolved
@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Dec 16, 2019 •
edited

Perf comparision

Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
Button.Fluent 1.35 0.14 9.64:1 5000 6726
Checkbox.Fluent 1.5 0.28 5.36:1 5000 7482
Icon.Fluent 0.29 0.03 9.67:1 5000 1431
Slider.Fluent 1.77 0.27 6.56:1 5000 8841

Generated by 🚫 dangerJS

mnajdova
mnajdova reviewed Dec 17, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@codepretty
Copy link
Collaborator

Why did this example not get the updated caret?
image

@notandrew
Copy link
Member Author

Why did this example not get the updated caret?
image

fixed it by rotating the icon

@notandrew notandrew merged commit 1b4b6b6 into master Jan 7, 2020
@notandrew notandrew deleted the fix/splitbutton-styles branch January 7, 2020 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mnajdova mnajdova mnajdova left review comments

@codepretty codepretty codepretty approved these changes

@silviuaavram silviuaavram silviuaavram approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@layershifter layershifter Awaiting requested review from layershifter layershifter is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@dzearing dzearing Awaiting requested review from dzearing dzearing is a code owner

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345 ecraig12345 is a code owner

@JasonGore JasonGore Awaiting requested review from JasonGore JasonGore is a code owner

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

@kenotron kenotron Awaiting requested review from kenotron kenotron is a code owner

Assignees
No one assigned
Labels
🚀 ready for review redlines Update of the redlines for the mentioned component 💅 styling issue teams theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@notandrew @DustyTheBot @codepretty @mnajdova @silviuaavram