This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(whatInput): cleanup previously added event listeners #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
commented
Nov 25, 2019
| if (eventTarget.PointerEvent) { | ||
| eventTarget.removeEventListener('pointerdown', setInput) | ||
| // @ts-ignore | ||
| } else if (window.MSPointerEvent) { |
There was a problem hiding this comment.
still thinking why here there is window and not eventTarget.
There was a problem hiding this comment.
I am replacing this. @jurokapsiar @layershifter any comments?
There was a problem hiding this comment.
this is basically a platform check - saying "does this browser have MSPointerEvent?"
There was a problem hiding this comment.
will revert it then, but shouldn't the check above mean similarly? eventTarget.PointerEvent
miroslavstastny
approved these changes
Nov 25, 2019
There was a problem hiding this comment.
Approved, it would be great if @jurokapsiar could check it as well as he originally added multi-window support
| </Provider>, | ||
| ) | ||
|
|
||
| expect(addEventListener).toHaveBeenCalledTimes(5) |
There was a problem hiding this comment.
There was a problem hiding this comment.
ok ok will add a comment why :))))
| @@ -87,14 +89,14 @@ const addListeners = (eventTarget: Window) => { | |||
| // `pointermove`, `MSPointerMove`, `mousemove` and mouse wheel event binding | |||
| // can only demonstrate potential, but not actual, interaction | |||
| // and are treated separately | |||
| const options = supportsPassive ? { passive: true, useCapture: true } : true | |||
| const options = supportsPassive ? { passive: true, capture: true } : true | |||
miroslavstastny
pushed a commit
that referenced
this pull request
Nov 26, 2019
* cleanup event listeners * type check improvement * replace window occurance * add tests * changelog * improve tests * revert change of window
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2109
Counting on
target[whatInputInitialized]the number of Providers requesting to setup the custom-target whatInput.To cleanup, in Provider
componentWillUnmountwe will attempt to remove listeners. If there are still Providers running (target[whatInputInitialized] > 1) then we will decrement that value. If it's the last one, then we perform cleanup.Extra:
whatInput.tsI changeduseCapturewithcapture(line 92). According to the docs that is the correct property if we pass the information inside theoptionsobject params.To Do:
Microsoft Reviewers: Open in CodeFlow