This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Divider): add vertical prop #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
mnajdova
reviewed
Dec 17, 2019
|
|
||
| const DividerVerticalExampleShorthand = () => ( | ||
| <div style={{ display: 'flex', justifyContent: 'center', height: '32px', alignItems: 'center' }}> | ||
| <Divider vertical /> |
There was a problem hiding this comment.
Should we support vertical Divider with content? Just curious how would it look like
There was a problem hiding this comment.
If this is the case I believe it would complicate the styles in some way, as we will need to "leave space" between the two parts of the divider for the text..
There was a problem hiding this comment.
It wasn't a requirement so far. If it's with content then it changes significantly, as it will be | content | instead of just |. While the horizontal one is still a one liner. Do you think we need to handle this case now or can it be left for when we really need it?
There was a problem hiding this comment.
If Teams needs doesn't need this, then it's okay.
silviuaavram
force-pushed
the
feat/vertical-divider
branch
from
e42be2b
to
191ae68
Compare
mnajdova
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divider should now support the
verticalprop which will position the Divider vertically.Microsoft Reviewers: Open in CodeFlow