Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Tooltip): make tooltipAsLabelBehavior as default behavior #2195

Merged
merged 5 commits into from
Dec 20, 2019

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Dec 19, 2019

Makes tooltipAsLabelBehavior as default behavior for Tooltip.
Renames tooltipBehavior to tooltipAsDescriptionBehavior, refactors its tests and improves other behavior tests.

Closes #2128

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Dec 19, 2019

Perf comparision

Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
Button.Fluent 1.19 0.12 9.92:1 5000 5965
Checkbox.Fluent 1.38 0.23 6:1 5000 6921
Icon.Fluent 0.26 0.03 8.67:1 5000 1315
Slider.Fluent 1.82 0.27 6.74:1 5000 9086

Generated by 🚫 dangerJS

@silviuaavram silviuaavram changed the title improve behavior tests fix(Tooltip): make tooltipAsLabelBehavior as default behavior Dec 20, 2019
@silviuaavram silviuaavram merged commit a3268c5 into master Dec 20, 2019
@silviuaavram silviuaavram deleted the fix/tooltip-behavior-improvement branch December 20, 2019 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility All the Accessibility tasks and bugs should be tagged with this. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TooltipBehavior can cause double narration under specific conditions
3 participants