This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(List): add proper support for children API #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed dependencies are detected.Changed dependencies in
Perf comparison
Potential regressions comparing to master
Perf tests with no regressions
Generated by 🚫 dangerJS |
layershifter
force-pushed
the
proto/list-context
branch
from
0d29ba2
to
ae9b5a3
Compare
layershifter
force-pushed
the
proto/list-context
branch
from
ae9b5a3
to
3cea7da
Compare
layershifter
force-pushed
the
proto/list-context
branch
from
0ddcd33
to
3d3b429
Compare
joschect
reviewed
Jan 28, 2020
layershifter
added
⚙️ enhancement
| } | ||
| }, | ||
| }) | ||
| [actions], |
There was a problem hiding this comment.
Having actions as the only dependency means you can get stale props in onSelectedIndexChange cb.
There was a problem hiding this comment.
Yep, you're totally right. I will tackle this separately
| variables, | ||
| } = props | ||
|
|
||
| const parentProps = useContextSelectors(ListContext, { |
There was a problem hiding this comment.
The typings does not seem to be strict enough to allow only the valid keys and values.
Let's verify it together offline.
…m/stardust-ui/react into proto/list-context � Conflicts: � packages/react-context-selector/README.md � packages/react-context-selector/package.json � packages/react-context-selector/src/createContext.ts � packages/react-context-selector/src/index.ts � packages/react-context-selector/src/types.ts � packages/react-context-selector/src/useContextSelector.ts � packages/react-context-selector/src/useContextSelectors.ts � packages/react-context-selector/test/createContext-test.tsx
layershifter
changed the title
layershifter
requested review from
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason and
mnajdova
as code owners
…m/stardust-ui/react into proto/list-context � Conflicts: � docs/src/examples/components/List/Performance/index.tsx � packages/react-bindings/src/hooks/useStateManager.ts � packages/react-bindings/test/hooks/useAutoControlled-test.tsx � packages/react-bindings/test/hooks/useStateManager-test.tsx
miroslavstastny
approved these changes
Feb 14, 2020
…m/stardust-ui/react into proto/list-context � Conflicts: � CHANGELOG.md
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
context-selectorsto add full support for Children API inListcomponent.Performance 🏎
There is no real difference between shorthand/Context usage.
With Context usage
Previous implementation