This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(AlertBehavior) add missing aria-describedby to AlertBehavior when… #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type is different than warning/danger microsoft#2197
delprzemo
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Perf comparison
Potential regressions comparing to master
Perf tests with no regressions
Generated by 🚫 dangerJS |
|
Need a tip how can I fix screener tests in that case. Edit. After checking screener.yml I guess it may be related to branch and PR via fork |
jurokapsiar
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
@delprzemo sorry for the delay, this looks good. please update the branch to master and check if the changelog entry gets to the unreleased section. thanks for your contribution!
delprzemo
pushed a commit
to delprzemo/fluent-ui-react
that referenced
this pull request
Jan 31, 2020
@jurokapsiar No problem. Branch updated to master - changelog entry in the unreleased section. I don't have write access so could you merge it? |
|
foreced push despite failing screener - currently the integration does not work for forked repos. This PR does not introduce any visual changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue with lack of
aria-describedbyinAlertBehaviorwhen dismiss action is defined and type is different than warning/dangerFixes #2197