This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore(package): create styles package #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
force-pushed
the
chore/create-styles
branch
from
7923742
to
cf5e28d
Compare
layershifter
commented
Jan 10, 2020
| @@ -17,7 +17,6 @@ const flexItemStyles: ComponentSlotStylesPrepared<FlexItemProps, FlexItemVariabl | |||
| ...(p.grow && { flexGrow: p.grow }), | |||
| ...(p.grow === true && { flexGrow: 1 }), | |||
|
|
|||
| ...p.itemStyles, | |||
There was a problem hiding this comment.
This prop was cruft
Changed dependencies are detected.Changed dependencies in
Changed dependencies are detected.Changed dependencies in
Perf comparison
Generated by 🚫 dangerJS |
# Conflicts: # packages/react-bindings/tsconfig.json # packages/react/tsconfig.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big movement ⏩
This PR moves all styles related utilities and Typescript types to a separate
@fluentui/stylespackage to avoid circular dependencies between@fluentui/reactand@fluentui/react-bindings. Extracted utilities are considered as framework agnostic (hopefully 🐱 ), all React related things should be moved and will be moved to@fluentui/react-bindingsin a separate PR.Potentially breaking changes
ICSSInJSStyletype is not anymore extendingReact.CSSProperties, so you can't assignICSSInJSStyletoReact.CSSPropertiesanymore - you have to use type cast.