This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusZone): Event listener leak in inner FZ #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason and
mnajdova
as code owners
dzearing
reviewed
Jan 10, 2020
Perf comparison
Generated by 🚫 dangerJS |
dzearing
approved these changes
Jan 12, 2020
miroslavstastny
added a commit
that referenced
this pull request
Jan 17, 2020
* fix(FocusZone): Event listener leak in inner FZ * - remove event listener only when unmounting (the last) outer zone * - changelog
miroslavstastny
added a commit
that referenced
this pull request
Jan 30, 2020
* fix(FocusZone): Event listener leak in inner FZ * - remove event listener only when unmounting (the last) outer zone * - changelog (cherry picked from commit 21c64fa)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2219.
Only the first outer zone is supposed to attach keydown event listener to window.
Previously,
FocusZonealways added the listener when there was exactly one outer zone. That did not match theremoveEventListenerlogic incomponentWillUnmountintroduced in #2056.