Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Colors): Add new color scheme design token for Teams theme #2297

Merged
merged 3 commits into from
Feb 4, 2020

Conversation

codepretty
Copy link
Collaborator

image

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Jan 30, 2020

Warnings
⚠️ 1 perf regressions detected

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.62 0.4 1.55:1 2000 1231
🔧 Button.Fluent 1.23 0.17 7.24:1 1000 1232
🔧 Checkbox.Fluent 1.37 0.32 4.28:1 1000 1374
🔧 Dialog.Fluent 0.34 0.19 1.79:1 5000 1715
🔧 Dropdown.Fluent 3.55 0.36 9.86:1 1000 3553
🔧 Icon.Fluent 0.24 0.03 8:1 5000 1183
🔧 Image.Fluent 0.1 0.07 1.43:1 5000 481
🔧 Slider.Fluent 1.98 0.3 6.6:1 1000 1977
🦄 Text.Fluent 0.05 0.17 0.29:1 5000 257
🦄 Tooltip.Fluent 0.46 20.03 0.02:1 5000 2322

🔧 Needs work     🎯 On target     🦄 Amazing

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 217 226 0.96:1
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
SplitButtonMinimalPerf.default 11601 0 Infinity:1
PortalMinimalPerf.default 333 261 1.28:1
RefMinimalPerf.default 202 159 1.27:1
DropdownManyItemsPerf.default 527 443 1.19:1
ButtonSlotsPerf.default 2094 1802 1.16:1
Slider.Fluent 1977 1834 1.08:1
IconMinimalPerf.default 1079 1012 1.07:1
InputMinimalPerf.default 1006 951 1.06:1
TextMinimalPerf.default 261 247 1.06:1
TreeMinimalPerf.default 886 839 1.06:1
AvatarMinimalPerf.default 613 585 1.05:1
HierarchicalTreeMinimalPerf.default 751 717 1.05:1
Dropdown.Fluent 3553 3398 1.05:1
DialogMinimalPerf.default 1632 1564 1.04:1
PopupMinimalPerf.default 379 365 1.04:1
RadioGroupMinimalPerf.default 382 366 1.04:1
ToolbarMinimalPerf.default 825 796 1.04:1
Avatar.Fluent 1231 1178 1.04:1
Text.Fluent 257 248 1.04:1
ChatDuplicateMessagesPerf.default 531 516 1.03:1
FlexMinimalPerf.default 328 318 1.03:1
LayoutMinimalPerf.default 483 467 1.03:1
Icon.Fluent 1183 1145 1.03:1
ButtonMinimalPerf.default 1355 1331 1.02:1
CarouselMinimalPerf.default 1829 1786 1.02:1
EmbedMinimalPerf.default 6109 5968 1.02:1
HeaderSlotsPerf.default 1218 1193 1.02:1
ListMinimalPerf.default 686 675 1.02:1
SegmentMinimalPerf.default 1285 1256 1.02:1
Dialog.Fluent 1715 1675 1.02:1
CheckboxMinimalPerf.default 6723 6679 1.01:1
DropdownMinimalPerf.default 3377 3333 1.01:1
AlertMinimalPerf.default 552 551 1:1
ChatWithPopoverPerf.default 535 537 1:1
DividerMinimalPerf.default 849 848 1:1
LabelMinimalPerf.default 1650 1654 1:1
ProviderMergeThemesPerf.default 1082 1081 1:1
ItemLayoutMinimalPerf.default 1582 1604 0.99:1
ReactionMinimalPerf.default 2518 2556 0.99:1
FormMinimalPerf.default 684 696 0.98:1
GridMinimalPerf.default 753 771 0.98:1
CustomToolbarPrototype.default 3849 3927 0.98:1
TooltipMinimalPerf.default 2374 2418 0.98:1
Tooltip.Fluent 2322 2374 0.98:1
AttachmentSlotsPerf.default 3210 3325 0.97:1
ChatMinimalPerf.default 1592 1646 0.97:1
ProviderMinimalPerf.default 593 611 0.97:1
TableMinimalPerf.default 527 543 0.97:1
HeaderMinimalPerf.default 401 419 0.96:1
AnimationMinimalPerf.default 438 460 0.95:1
AttachmentMinimalPerf.default 906 952 0.95:1
MenuMinimalPerf.default 1786 1882 0.95:1
SliderMinimalPerf.default 1856 1946 0.95:1
StatusMinimalPerf.default 820 864 0.95:1
ImageMinimalPerf.default 473 502 0.94:1
TextAreaMinimalPerf.default 2804 2997 0.94:1
Button.Fluent 1232 1315 0.94:1
ListCommonPerf.default 1033 1108 0.93:1
LoaderMinimalPerf.default 2313 2493 0.93:1
MenuButtonMinimalPerf.default 1413 1542 0.92:1
Image.Fluent 481 521 0.92:1
VideoMinimalPerf.default 698 791 0.88:1
Checkbox.Fluent 1374 1611 0.85:1
AccordionMinimalPerf.default 190 237 0.8:1

Generated by 🚫 dangerJS

@codepretty codepretty merged commit ddf6298 into master Feb 4, 2020
@codepretty codepretty deleted the colorscheme-redhover2-add branch February 4, 2020 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants