This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusZone): Cleanup DOM element references on unmount #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason and
mnajdova
as code owners
miroslavstastny
changed the title
layershifter
reviewed
Feb 2, 2020
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
layershifter
approved these changes
Feb 3, 2020
miroslavstastny
added a commit
that referenced
this pull request
Feb 3, 2020
* fix(FocusZone): Cleanup DOM element references when component is unmounted The FocusZone component holds references to _activeElement and _defaultFocusElement. These references should be nulled out when the component is unmounted to prevent memory leaks. closes #2303 (cherry picked from commit 6a9282f) * Change log update (cherry picked from commit b31cf02) * Fix typos (cherry picked from commit 8024cd0) * One more typo (cherry picked from commit 1ded3ad) * fixed changelog order Co-authored-by: Johanna Hawkins <jo.hawkins@hotmail.com> (cherry picked from commit 2cbf4ad)
miroslavstastny
added a commit
that referenced
this pull request
Feb 3, 2020
* fix(FocusZone): Cleanup DOM element references when component is unmounted The FocusZone component holds references to _activeElement and _defaultFocusElement. These references should be nulled out when the component is unmounted to prevent memory leaks. closes #2303 (cherry picked from commit 6a9282f) * Change log update (cherry picked from commit b31cf02) * Fix typos (cherry picked from commit 8024cd0) * One more typo (cherry picked from commit 1ded3ad) * fixed changelog order Co-authored-by: Johanna Hawkins <jo.hawkins@hotmail.com> (cherry picked from commit 2cbf4ad)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FocusZone component holds references to _activeElement and _defaultFocusElement. These references should be nulled out when the component is unmounted to prevent memory leaks.
Fixes #2303
Note: this was just moved from @johannao76 fork, all credit goes to her.