This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore: move more components #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
force-pushed
the
chore/move-more-components
branch
2 times, most recently
from
3d1f5a1
to
d4e3a24
Compare
layershifter
force-pushed
the
chore/move-more-components
branch
from
9a1d24f
to
bc81b50
Compare
Perf comparison
Potential regressions comparing to master
Perf tests with no regressions
Generated by 🚫 dangerJS |
mnajdova
reviewed
Feb 4, 2020
mnajdova
reviewed
Feb 4, 2020
| const { disabled } = this.props | ||
| const checked = !this.state.checked | ||
| const handleClick = (e: React.MouseEvent | React.KeyboardEvent) => { | ||
| const checked = !state.checked |
There was a problem hiding this comment.
nit: move this line in the condition below
mnajdova
reviewed
Feb 4, 2020
mnajdova
reviewed
Feb 4, 2020
mnajdova
reviewed
Feb 4, 2020
mnajdova
reviewed
Feb 4, 2020
|
|
||
| return ( | ||
| <ElementType {...getA11Props('root', { className: classes.root, ...unhandledProps })}> | ||
| {isSvgIcon && callable(maybeIcon.icon)({ classes, rtl: context.rtl, props })} |
There was a problem hiding this comment.
Maybe we should restrict the props sent here too. Not as part of this PR, though
There was a problem hiding this comment.
Agree, let's do it separately. I am even not sure that should pass there something
mnajdova
reviewed
Feb 4, 2020
mnajdova
reviewed
Feb 4, 2020
| const { classes, styles: resolvedStyles } = useStyles(Label.displayName, { | ||
| className: Label.className, | ||
| mapPropsToStyles: () => ({ | ||
| hasActionableIcon: _.has(icon, 'onClick'), |
mnajdova
reviewed
Feb 4, 2020
mnajdova
reviewed
Feb 4, 2020
mnajdova
reviewed
Feb 4, 2020
mnajdova
reviewed
Feb 4, 2020
| @@ -124,7 +124,7 @@ exports[`felaRenderer marginLeft is rendered into marginLeft due to RTL with \`n | |||
|
|
|||
|
|
|||
| <div className=ui-provider__box dir=rtl> | |||
| <span className=ui-text a dir=auto> | |||
| <span dir=auto className=ui-text a> | |||
There was a problem hiding this comment.
I wonder why these are changed :\
There was a problem hiding this comment.
Small issue, I fixed order of props in Text and reverted this change 👍
mnajdova
reviewed
Feb 4, 2020
…ithub.com/stardust-ui/react into chore/move-more-components � Conflicts: � CHANGELOG.md
mnajdova
reviewed
Feb 6, 2020
| /** Alternative text. */ | ||
| alt?: string | ||
| 'aria-label'?: string |
mnajdova
reviewed
Feb 6, 2020
| ...commonPropTypes.createCommon({ | ||
| children: false, | ||
| content: false, | ||
| const iconElement = Icon.create(icon, { |
mnajdova
reviewed
Feb 6, 2020
| const { className, color, icon, size, state, design, styles, variables } = props | ||
| const { classes, styles: resolvedStyles } = useStyles(Status.displayName, { | ||
| className: Status.className, | ||
| mapPropsToStyles: () => ({ |
There was a problem hiding this comment.
Let's update the statusStyles with the new typings
mnajdova
reviewed
Feb 6, 2020
| @@ -106,15 +106,15 @@ export type TeamsThemeStylesProps = { | |||
| Reaction?: ReactionProps | |||
| ReactionGroup?: ReactionGroupProps | |||
| Segment?: SegmentProps | |||
| Slider?: SliderProps | |||
| Slider?: SliderStylesProps | |||
…ithub.com/stardust-ui/react into chore/move-more-components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Only specific props are now passed to component's style functions.
CheckboxcheckeddisabledlabelPositiontoggleIconborderedcircularcolordisablednameoutlinerotatesizexSpacingisFontIconisSvgIconLabelhasActionableIconhasImagecircularcolorimagePositionSliderfluidverticaldisabledStatuscolorsizestateTextatMentioncolorimportanttimestamptruncateddisablederrorsuccesstemporaryalignweightsize